jvm -> scala version in sbt, not yml#899
Merged
lrytz merged 1 commit intolightbend-labs:mainfrom Feb 16, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This pull request refactors the build configuration to move Scala version selection from GitHub Actions workflow files into the sbt build definition. The change introduces a Java version-based approach where the build automatically selects appropriate Scala versions based on the Java runtime version being used (Java 8 vs Java 17+).
Changes:
- Introduced
java8or17helper function to conditionally set Scala versions based on Java runtime - Consolidated build settings into
commonSettingssequence applied to all projects - Simplified CI and release workflows by removing explicit Scala version matrices and using sbt's native cross-building commands
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| build.sbt | Added Java version detection logic, consolidated common settings, updated Scala version variables (scala3 → scala3_3, added scala3_8), and applied dynamic crossScalaVersions configuration to all projects |
| .github/workflows/release.yml | Simplified from separate jobs for core/cli and sbtplugin to a single unified release job using ci-release |
| .github/workflows/ci.yml | Removed explicit Scala version matrix, replaced with +test and +sbtplugin/scripted for cross-version testing |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.