Skip to content

Fix for #783 #784

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix for #783 #784

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
800a639
Fix for #783? Unit test needed.
May 18, 2017
36ad1d3
Allow referenced fields to be set to null and only null
Jun 7, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion crud/src/main/java/com/redhat/lightblue/eval/SetExpressionEvaluator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,9 @@ public SetExpressionEvaluator(JsonNodeFactory factory, FieldTreeNode context, Se
} else if (mdNode instanceof ArrayField) {
data = initializeArray(rvalue, refMdNode, mdNode, field, refPath);
}
setValues.add(data);
if (data != null) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this would work, but we should also add an if statement before instanceof ArrayField (becayse ResolvedReferenceField extends ArrayField)

if(mdNode instanceof ResolvedReferenceField) {
// then, if the set-to value is null, set data to null, so it won't be added to setValues. If it is non-null, throw error, because the call is setting a reference to a non-null value.
}

setValues.add(data);
}
}
}

Expand Down