Skip to content

Conversation

dcrissman
Copy link
Member

This is a rename only, but it will require lightblue-metadata to be updated in downstream projects.

@dcrissman dcrissman self-assigned this Oct 2, 2015
@dcrissman
Copy link
Member Author

This handles the class rename part of #38

@jewzaam
Copy link
Member

jewzaam commented Oct 6, 2015

Why call the classes "EsbPublishHook" instead of "EsbHook" The repo would indicate the latter. "Publish" is a throwback to the older name "lightblue-publish-hook"

@dcrissman
Copy link
Member Author

I am fine with that. I will make the change.

@dcrissman
Copy link
Member Author

Tagging @paterczm as some follow up merges will be needed once this is merged

@jewzaam
Copy link
Member

jewzaam commented Oct 6, 2015

Looking at this a bit deeper and it's a breaking change due to configuration. Recommend we keep a deprecated PublishHookConfigurationParser class even if it simply extends EsbHookConfigurationParser. I assume as-is a hot deployment will have problems. If I'm wrong and this is tested and OK this should be fine, but it doesn't hurt to keep it in for a little bit.

@dcrissman
Copy link
Member Author

It can wait

@dcrissman
Copy link
Member Author

Moving out of in-progress and setting as open questions as we are waiting on a decision about #51.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants