If streaming, don't compute result set size #370
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paterczm
reviewed
Jun 22, 2017
| @@ -85,7 +85,7 @@ public long find(CRUDOperationContext ctx, | |||
| cursor.setReadPreference(readPreference); | |||
| } | |||
|
|
|||
| if (maxQueryTimeMS > 0) { | |||
| if (maxQueryTimeMS > 0&&ctx.isLimitQueryTime()) { | |||
There was a problem hiding this comment.
Why this new isLimitQueryTime flag?
There was a problem hiding this comment.
I added that thinking with streaming, there is no need, but that will still be useful if you submit a long running query, so it is there just in case.
There was a problem hiding this comment.
Still don't know why maxQueryTimeMS is not enough in streaming context.
|
|
||
| int numMatched=0; | ||
| int nRetrieve=0; | ||
| if(ctx.isComputeMatchCount()) { |
There was a problem hiding this comment.
Perhaps we can rename this flag to computeCounts and use it for modifiedCount too? lightblue-platform/lightblue-core#789
|
It is enough. What I wanted to do is to not limit query times for
streaming, but then I have second thoughts about it. So, we're still
limiting long running queries, but we may consider disabling that for
streaming finds.
…On Thu, Jun 22, 2017 at 10:04 AM, Marek ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In mongo/src/main/java/com/redhat/lightblue/mongo/crud/BasicDocFinder.java
<#370 (comment)>
:
> @@ -85,7 +85,7 @@ public long find(CRUDOperationContext ctx,
cursor.setReadPreference(readPreference);
}
- if (maxQueryTimeMS > 0) {
+ if (maxQueryTimeMS > 0&&ctx.isLimitQueryTime()) {
Still don't know why maxQueryTimeMS is not enough in streaming context.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#370 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ADgDDd-r8FGFQLIafS2VdWuXYZjOWY6Aks5sGpCrgaJpZM4OCVo5>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.