Skip to content

Deal status refactoring and code improvements #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

Deal status refactoring and code improvements #9

wants to merge 11 commits into from

Conversation

lordshashank
Copy link

Does following changes -

  • Removed unnecessary deployment of libraries with dealStatus contract
  • Made dealStatus compatible with read-only funcitons of filecoin-solidity library
  • Created public function to get deal info from market API (can be made internal later if needed)
  • Created deal-info task to test the market API functionality of dealStatus contract
  • Improved code of dealStatus contract

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nandit123 nandit123 Awaiting requested review from nandit123

@ravish1729 ravish1729 Awaiting requested review from ravish1729

@parva-jain parva-jain Awaiting requested review from parva-jain

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@lordshashank