Change PascalVOC input interface to InstanceSegmentationInput#56
Merged
michal-lightly merged 4 commits intomainfrom Jan 15, 2026
Merged
Conversation
Contributor
Author
|
/review |
MalteEbner
approved these changes
Jan 15, 2026
Contributor
MalteEbner
left a comment
MalteEbner
left a comment
There was a problem hiding this comment.
LGTM, well done!
This makes the SemanticSegmentationMask internal - it is not used as an LabelInput class interface.
To consider: Should we name the class differently? (Would be for a follow-up PR.)
Would rename it to _SemanticSegmentationMask and add a comment that it is internal-only. Feel free to do it in this PR
michal-lightly
deleted the
michal-lig-8013-semanticsegmentation-loading-in-lightlystudio-5
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What has changed and why?
Change PascalVOC input interface to InstanceSegmentationInput.
After a discussion with @MalteEbner, we decided to change the interface to InstanceSegmentationInput for semantic segmentations. This matches the pattern established for instance segmentations. Since the returned data format is the same there's no need for a new class.
This makes the SemanticSegmentationMask internal - it is not used as an LabelInput class interface.
To consider: Should we name the class differently? (Would be for a follow-up PR.)
How has it been tested?
Added a new test.