Skip to content

Conversation

@yutong-xiang-97
Copy link
Contributor

@yutong-xiang-97 yutong-xiang-97 commented Jun 27, 2025

  • Provide DINOv2 examples with PyTorch, Lightning, and Distributed (tested by running the script). The layerwise lr decay and gradient clipping are removed for simplicity, as done similarly in DINO's example.
  • Add to docs the model example page.
    DINOv2 — lightly 1.5.21 documentation.pdf

@codecov
Copy link

codecov bot commented Jun 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.76%. Comparing base (92e53dc) to head (7c38043).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1849   +/-   ##
=======================================
  Coverage   85.76%   85.76%           
=======================================
  Files         166      166           
  Lines        6946     6946           
=======================================
  Hits         5957     5957           
  Misses        989      989           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@stegmuel stegmuel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments/suggestions.

Copy link
Contributor

@stegmuel stegmuel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added pointers to comments that do not follow our convention.

Copy link
Contributor

@stegmuel stegmuel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@yutong-xiang-97 yutong-xiang-97 merged commit b9237a2 into master Jun 30, 2025
15 checks passed
@yutong-xiang-97 yutong-xiang-97 deleted the yutong-trn-583-lightlyssl-add-dinov2-to-docs-with-example branch June 30, 2025 13:41
@liopeer liopeer mentioned this pull request Aug 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants