optimize the update loop #695
Conversation
chiefcll
force-pushed
the
optUpdateLoop
branch
from
ef0c89a to
fd12df2
Compare
| let updateParent = false; | ||
| // reset update type | ||
| this.updateType = 0; | ||
| this.childUpdateType = 0; |
There was a problem hiding this comment.
Reset happens at beginning of loop rather than end
|
|
||
| if (this.renderState === CoreNodeRenderState.OutOfBounds) { | ||
| updateType &= ~UpdateType.RenderBounds; // remove render bounds update | ||
| this.updateType = updateType; |
There was a problem hiding this comment.
This just needed to be set back. Before this updateType &= ~UpdateType.RenderBounds; was doing nothing as it was changing a local variable and then returning
| let childClippingRect = this.clippingRect; | ||
|
|
||
| if (this.rtt === true) { | ||
| childClippingRect = NO_CLIPPING_RECT; | ||
| } |
There was a problem hiding this comment.
Move this check outside the for loop as its for the parent and not each child
| if (childUpdateType !== 0) { | ||
| child.setUpdateType(childUpdateType); | ||
| } |
There was a problem hiding this comment.
Skip updating all children nodes and parent nodes if we're just resetting anyhow.
| if (this.updateType === UpdateType.None) { | ||
| return; | ||
| } |
There was a problem hiding this comment.
This is not needed as the child for loop checks this.
|
Also I believe the test is broken as the code was broken before... Expected says red rectangle is out of bounds, when it is In bounds. With the update, the red rectangle is in the viewport. |
2 participants
See comments in line - #687 can be closed out for this PR