Skip to content

feat: add full cleanup flag for textures #717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wouterlucas merged 2 commits into from
Jan 21, 2026
Merged

feat: add full cleanup flag for textures #717

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3d66b6c
feat: add full cleanup flag for textures
chiefcll Jan 18, 2026
301e3ce
do boolean check
chiefcll Jan 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/core/Stage.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -888,8 +888,8 @@ export class Stage {
* @remarks
* This method is used to cleanup orphaned textures that are no longer in use.
*/
cleanup() {
this.txMemManager.cleanup();
cleanup(full: boolean = false) {
this.txMemManager.cleanup(full);
}

set clearColor(value: number) {
Expand Down
6 changes: 3 additions & 3 deletions src/core/TextureMemoryManager.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -253,7 +253,7 @@ export class TextureMemoryManager {
texture.memUsed = 0;
}

cleanup() {
cleanup(full: boolean = false) {
const critical = this.criticalCleanupRequested;
this.lastCleanupTime = this.frameTime;

Expand All @@ -266,7 +266,7 @@ export class TextureMemoryManager {

if (this.debugLogging === true) {
console.log(
`[TextureMemoryManager] Cleaning up textures. Critical: ${critical}.`,
`[TextureMemoryManager] Cleaning up textures. Critical: ${critical}. Full: ${full}`,
);
}

Expand All @@ -279,7 +279,7 @@ export class TextureMemoryManager {

for (let i = 0; i < this.loadedTextures.length; i++) {
// Early exit: target memory reached
if (currentMemUsed < memTarget) {
if (!full && currentMemUsed < memTarget) {
break;
}

Expand Down