update addQuad to take CoreNode instances#726
Merged
jfboeve merged 1 commit intolightning-js:v3/prc-beta-21from Feb 4, 2026
Merged
update addQuad to take CoreNode instances#726jfboeve merged 1 commit intolightning-js:v3/prc-beta-21from
jfboeve merged 1 commit intolightning-js:v3/prc-beta-21from
Conversation
Collaborator
|
This looks pretty good, I think i've tried this in the past but thought we might run into trouble if the w / h change during runtime since the other values are all "precalculated" in the update loop but w/h come straight out of the props. @wouterlucas thoughts? This does eliminate the creation of an object that is so unnecessary |
Collaborator
|
Merging this with prc-beta21 because there's some canvas stuff that needs to be done, and I want to run some benchmarks with this and 727 in the same base. |
jfboeve
added a commit
that referenced
this pull request
Feb 4, 2026
Phase 2 - after #726 Removes RenderOps and leaves it on CoreNode. Cleanup property differences between SDF & CoreNode
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Phase one of garbage collection cleanup. addQuad took in a new object which was basically a copy of CoreNode. This creates a lot of objects that need to be cleaned up. Instead simply passing in CoreNode makes more sense.
I'd like to continue cleanup of RenderOps and have CoreNode and SDF match interfaces. I think removing the RenderOp and simply having a draw() call on the CoreNode / SDF would be lot faster.