Add test vector for (invalid) mixed-case offer encoding#1217
Merged
t-bast merged 1 commit intolightning:masterfrom Feb 4, 2025
Merged
Add test vector for (invalid) mixed-case offer encoding#1217t-bast merged 1 commit intolightning:masterfrom
t-bast merged 1 commit intolightning:masterfrom
Conversation
The spec requires the bech32 offer encodings to be all upper- or lowercase, but disallows mixed-case encodings. Here, we add a test vector for this.
Collaborator
|
@thomash-acinq I don't know what eclair currently does: can you check and add this test vector? |
23 tasks
|
Eclair wasn't implementing this string format. It's added in ACINQ/eclair#2985 |
t-bast
approved these changes
Jan 27, 2025
Collaborator
|
Merging, as agreed during the last spec meeting. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The spec requires the bech32 offer encodings to be all upper- or lowercase, but disallows mixed-case encodings.
Here, we add a test vector checking for this.