summary: fixes and restores the summary plugin

[m-schmoock]

Just fixes the bits and pieces that got outdated here and nobody cared about.
Its always been a beautiful plugin.

[chrisguida]

🎉

[chrisguida]

Hi @m-schmoock - Since you are the official summary maintainer, can you please look into fixing these CI failures?

Once CI is failing all supported CLN versions, the plugin is considered unmaintained.

Thanks! 🙏

[m-schmoock]

@chrisguida I have been out of CLN for a very long time. Seems like test_summary.py::test_summary_peer_thread isn't running properly or is flaky. I doubt this is version specific, even though CI thinks that way.

[m-schmoock]

Thanks for pointing out, maybe i'll find the time...

[chrisguida]

Okay cool! Just a heads up, we will archive summary once it is failing all supported versions.

[m-schmoock]

Okay cool! Just a heads up, we will archive summary once it is failing all supported versions.

As you can see the tests are green for several days now. I'm pretty sure the testflake observed was due to high load on the test system. And the test requires multiple deamons to interact with each other.

[chrisguida]

Hmm yes you are correct, looks like things were especially flaky.

Thanks for checking, maybe we can tighten things up somehow..