Skip to content

Conversation

@rustaceanrob
Copy link
Contributor

Allows clippy to catch and lint violations of the MSRV without further LSP configuration

Copy link
Collaborator

@tnull tnull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, I'd rather consider setting the rust-version field in Cargo.toml, which, IIUC, should also work?

@jbesraa
Copy link
Contributor

jbesraa commented Nov 14, 2024

Hmm, I'd rather consider setting the rust-version field in Cargo.toml, which, IIUC, should also work?

In SV2 project the rust-version was used and caused rust-analyzer to not work with some text editors unless you edit the config within the text editor to align the versions(or with $ rustup use [MSRV]), which becomes annoying if you switch between different projects with different MSRV's. Not sure about the .clippy file though as we are not using it.

@tnull
Copy link
Collaborator

tnull commented Nov 14, 2024

In SV2 project the rust-version was used and caused rust-analyzer to not work with some text editors unless you edit the config within the text editor to align the versions(or with $ rustup use [MSRV]), which becomes annoying if you switch between different projects with different MSRV's. Not sure about the .clippy file though as we are not using it.

Huh, shouldn't it just be an issue for older versions? FWIW, building with a newer version than the given rust-version works fine?

@jbesraa
Copy link
Contributor

jbesraa commented Nov 14, 2024

For me, if I configure rust-analyzer to use stable toolchain in vim and specify a different version in Cargo.toml, rust-analyzer wont work in vim. Other people in the team reported similar issue with different text editor also.

Copy link
Collaborator

@tnull tnull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, going ahead and merging this.

@tnull tnull merged commit b86e87d into lightningdevkit:main Nov 26, 2024
12 of 13 checks passed
@rustaceanrob rustaceanrob deleted the clippy-11-12 branch November 26, 2024 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants