core: fixing the esplora error match #417
Conversation
Recent version of esplora (from v0.10) changed the error type, so this commit is reflecting the change. Link: lightningdevkit#412 Signed-off-by: Vincenzo Palazzo <[email protected]>
vincenzopalazzo
force-pushed
the
macros/esplora-api
branch
from
6eee955 to
dc46a9d
Compare
|
Ci look like unrelated? |
There was a problem hiding this comment.
Thanks, LGTM!
We may want also consider to removing the FIXME comment in a separate commit?
Mhh, while I still think it would be great to differentiate some error variants here (e.g. the 'transaction already known' error when trying to broadcast transactions that the Bitcoin Core node behind the Esplora server already has in its mempool), I suspect doing so via string matching might prove to be error prone/flaky after all. We could consider just dropping the FIXME, but also not sure if we shouldn't revisit in the future..
In any case, I'll go ahead and land this for now.
(Btw, minor nit: The commit message could be a bit more verbose in general, but in particular it's also esplora-client 0.7 that started shipping the HttpResponse error variant I believe, we just couldn't update for the longest time).
Oh so probably I had to git blame a little bit better in esplora-client. Sorry, if you can |
No worries, really nbd.! |
2 participants
A recent version of esplora (from v0.10) changed the error type, so this commit is reflecting the change.
Fixes #412
We may want also consider to removing the FIXME comment in a separate commit?