Skip to content

Navigation Menu

Appearance settings

GitHub Copilot
Write better code with AI

GitHub Spark New
Build and deploy intelligent apps

GitHub Models New
Manage and compare prompts

GitHub Advanced Security
Find and fix vulnerabilities

Actions
Automate any workflow
Codespaces
Instant dev environments

Issues
Plan and track work

Code Review
Manage code changes

Discussions
Collaborate outside of code

Code Search
Find more, search less
Explore

Why GitHub

Documentation

GitHub Skills

Blog
Integrations

GitHub Marketplace
View all features
By company size

Enterprises

Small and medium teams

Startups

Nonprofits
By use case

DevSecOps

DevOps

CI/CD

View all use cases
By industry

Healthcare

Financial services

Manufacturing

Government

View all industries
View all solutions
Topics

AI

DevOps

Security

Software Development

View all
Explore

Learning Pathways

Events & Webinars

Ebooks & Whitepapers

Customer Stories

Partners

Executive Insights
GitHub Sponsors
Fund open source developers
The ReadME Project
GitHub community articles
Repositories

Topics

Trending

Collections
Enterprise platform
AI-powered developer platform
Available add-ons

GitHub Advanced Security
Enterprise-grade security features

Copilot for business
Enterprise-grade AI features

Premium Support
Enterprise-grade 24/7 support
Pricing

Search code, repositories, users, issues, pull requests...

Search

Clear

Search syntax tips

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted

Saved searches

Use saved searches to filter your results more quickly

Name

Query

To see all available qualifiers, see our documentation.

Appearance settings

You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session. You switched accounts on another tab or window. Reload to refresh your session.

Dismiss alert

lightningdevkit / ldk-node Public

Notifications You must be signed in to change notification settings
Fork 112
Star 181

Code
Issues 75
Pull requests 11
Actions
Projects
Security
Insights

Additional navigation options

Code
Issues
Pull requests
Actions
Projects
Security
Insights

Include onchain transactions in events#448

Draft

tnull wants to merge 7 commits intolightningdevkit:mainlightningdevkit/ldk-node:mainfrom

tnull:2025-01-include-onchain-transactions-in-eventstnull/ldk-node:2025-01-include-onchain-transactions-in-eventsCopy head branch name to clipboard

Conversation Commits7 (7)Checks Files changed

Draft

Include onchain transactions in events#448
tnull wants to merge 7 commits intolightningdevkit:mainfrom
tnull:2025-01-include-onchain-transactions-in-events

Commits

Commits on Jan 27, 2025

Prefactor: Only update `PaymentDetails` fields if necessary
tnull
committed
Prefactor: Implement `PaymentStore::batch_update`
tnull
committed
Add required fields to `PaymentKind::Onchain`
tnull
committed
Have `Wallet` take `PaymentStore` ref
tnull
committed
Update `PaymentStore` after each `Wallet` sync
tnull
committed
Have `Wallet` take `EventQueue` and `ChannelManager` refs
tnull
committed
Add and emit `OnchainPaymentSuccessful` and `OnchainPaymentReceived` events
tnull
committed

Footer

© 2025 GitHub, Inc.

Footer navigation

Terms
Privacy
Security
Status
Docs
Contact

You can’t perform that action at this time.