Skip to content

Cut v0.5.0 binary releases #533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 5, 2025
Merged

Cut v0.5.0 binary releases #533

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5fc9f13
Bump Kotlin/Swift/Python version numbers
tnull Apr 29, 2025
ef1e4b7
Use `stable` Rust toolchain for Swift builds
tnull Apr 28, 2025
35eba7b
Make minor adjustments to commented-out LDK deps
tnull May 5, 2025
682ed26
Update Swift files for v0.5.0
tnull May 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions scripts/uniffi_bindgen_generate_swift.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
#!/bin/bash
set -eox pipefail

BINDINGS_DIR="./bindings/swift"
UNIFFI_BINDGEN_BIN="cargo run --manifest-path bindings/uniffi-bindgen/Cargo.toml"

Expand All @@ -8,19 +10,19 @@ $UNIFFI_BINDGEN_BIN generate bindings/ldk_node.udl --language swift -o "$BINDING
mkdir -p $BINDINGS_DIR

# Install rust target toolchains
rustup install 1.73.0
rustup component add rust-src --toolchain 1.73.0
rustup target add aarch64-apple-ios x86_64-apple-ios --toolchain 1.73.0
rustup target add aarch64-apple-ios-sim --toolchain 1.73.0
rustup target add aarch64-apple-darwin x86_64-apple-darwin --toolchain 1.73.0
rustup upgrade stable
Copy link
Contributor

@joostjager joostjager May 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this remain deterministic?

Copy link
Contributor

@joostjager joostjager May 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clarified offline. Stable now surpassed 1.73.0

rustup component add rust-src --toolchain stable
rustup target add aarch64-apple-ios x86_64-apple-ios --toolchain stable
rustup target add aarch64-apple-ios-sim --toolchain stable
rustup target add aarch64-apple-darwin x86_64-apple-darwin --toolchain stable

# Build rust target libs
cargo build --profile release-smaller --features uniffi || exit 1
cargo build --profile release-smaller --features uniffi --target x86_64-apple-darwin || exit 1
cargo build --profile release-smaller --features uniffi --target aarch64-apple-darwin || exit 1
cargo build --profile release-smaller --features uniffi --target x86_64-apple-ios || exit 1
cargo build --profile release-smaller --features uniffi --target aarch64-apple-ios || exit 1
cargo +1.73.0 build --release --features uniffi --target aarch64-apple-ios-sim || exit 1
cargo +stable build --release --features uniffi --target aarch64-apple-ios-sim || exit 1

# Combine ios-sim and apple-darwin (macos) libs for x86_64 and aarch64 (m1)
mkdir -p target/lipo-ios-sim/release-smaller || exit 1
Expand Down