Skip to content

Refactor unified_qr.rs to use bitcoin-payment-instructions #607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Refactor unified_qr.rs to use bitcoin-payment-instructions #607

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
8e190ee
Rename unified_qr to unified
chuksys Aug 2, 2025
1903144
rename UnifiedQRPayment to UnifiedPayment, rename QRPaymentResult to …
chuksys Aug 2, 2025
7961b8f
add bitcoin-payment-instructions to cargo.toml
chuksys Aug 2, 2025
6ff4e41
Add hrn_resolver to Node
chuksys Aug 11, 2025
0d7fc1c
Pass hrn_resolver into UnifiedPayment and update unified.rs docs
chuksys Aug 11, 2025
8c78b5d
Refactor unified.rs to support sending to BIP 21 URIs as well as BIP …
chuksys Aug 11, 2025
7909c0f
Refactor unified_payment tests
chuksys Aug 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,7 @@ log = { version = "0.4.22", default-features = false, features = ["std"]}

vss-client = "0.3"
prost = { version = "0.11.6", default-features = false}
bitcoin-payment-instructions = { git = "https://github.com/rust-bitcoin/bitcoin-payment-instructions" }
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, @TheBlueMatt, can we get a bitcoin-payment-instructions release that includes rust-bitcoin/bitcoin-payment-instructions#6 ?

@chuksys In the meantime, please import a specific commit via rev = "..", as otherwise our builds might break as soon as bitcoin-payment-instructions's main changes.


[target.'cfg(windows)'.dependencies]
winapi = { version = "0.3", features = ["winbase"] }
Expand Down