Skip to content

Add support for resolving BIP 353 Human-Readable Names #630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 12 commits into
base: main
Choose a base branch
from
Draft

Add support for resolving BIP 353 Human-Readable Names #630

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
9ea92d5
Rename unified_qr to unified
chuksys Aug 2, 2025
b11fead
rename UnifiedQRPayment to UnifiedPayment, rename QRPaymentResult to …
chuksys Aug 2, 2025
998bdab
add bitcoin-payment-instructions to cargo.toml
chuksys Aug 2, 2025
55522b9
Add hrn_resolver to Node and pass into UnifiedPayment
chuksys Aug 11, 2025
f1d1fa1
Refactor unified.rs to support sending to BIP 21 URIs as well as BIP …
chuksys Aug 11, 2025
869839a
Fix typo in unified_payment send test and improve test name.
chuksys Aug 11, 2025
38e17d1
Switch to explicit imports in unified.rs mod tests
chuksys Aug 21, 2025
da52af8
Add lightning-dns-resolver to Cargo.toml
chuksys Sep 3, 2025
7973b8c
Enable setting Node as HRN Resolver for 3rd parties in Config
chuksys Sep 3, 2025
6068c1c
Pass HRNResolver or DomainResolver into OnionMessenger
chuksys Sep 4, 2025
2149475
Testing Node Ann Broadcast when node is_hrn_resolver
chuksys Sep 4, 2025
0517dbc
Add end-to-end test for HRN resolution
chuksys Sep 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,7 @@ log = { version = "0.4.22", default-features = false, features = ["std"]}
vss-client = "0.3"
prost = { version = "0.11.6", default-features = false}
bitcoin-payment-instructions = { version = "0.5" }
lightning-dns-resolver = "0.2.0"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add this above to the group(s) of lightning-* imports (also the commented-out ones) and follow the scheme there.


[target.'cfg(windows)'.dependencies]
winapi = { version = "0.3", features = ["winbase"] }
Expand Down