Revert batched VSS lazy deletes, rather spawn them into the background (backport)
#723
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…round Previously, we implemented `lazy` deletes in `VssStore` by batching them with the next write call as part of the next `PutObjectRequest` sent. However, we unfortunately overlooked that in this instance any non-existent `delete_items` would yield a `ConflictError`. Rather than batched `VssStore` lazy deletes, we therefore here opt to simply spawn them into the background and ignore any errors.
|
👋 Thanks for assigning @tankyleo as a reviewer! |
tnull
changed the title
lazy deletes, rather spawn them into the backgroundlazy deletes, rather spawn them into the background (backport)
tankyleo
approved these changes
Dec 2, 2025
tankyleo
left a comment
tankyleo
left a comment
There was a problem hiding this comment.
Do you want to include a pointer to the backported commit from main in the commit message ?
Collaborator
Author
Hmm, nah, I think it's fine for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we implemented
lazydeletes inVssStoreby batching them with the next write call as part of the nextPutObjectRequestsent. However, we unfortunately overlooked that in this instance any non-existentdelete_itemswould yield aConflictError. Rather than batchedVssStorelazy deletes, we therefore here opt to simply spawn them into the background and ignore any errors.