Skip to content

Initial chain access implementation #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

Initial chain access implementation #9

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
273617a
Add initial chain access implementation
tnull Nov 7, 2022
d5df624
Add `create_funding_transaction` method
tnull Nov 7, 2022
d9bc655
f Docs and typos
tnull Nov 10, 2022
39e56c7
f DON'T PANIC in large friendly letters
tnull Nov 10, 2022
d85730c
f Some restructuring, variable renaming
tnull Nov 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ lightning-background-processor = { version = "0.0.110" }
lightning-rapid-gossip-sync = { version = "0.0.110" }

#bdk = "0.20.0"
bdk = { git = "https://github.com/tnull/bdk", branch="feat/use-external-esplora-client", features = ["use-esplora-ureq", "key-value-db"]}
bdk = { git = "https://github.com/tnull/bdk", branch="feat/use-external-esplora-client", features = ["use-esplora-reqwest", "key-value-db"]}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How comfortable are we with taking on the reqwest dependency? @TheBlueMatt I believe you had a concern awhile back: lightningdevkit/rust-lightning#763 (comment)

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that's a bit out of date these days. I'd really love to avoid taking an HTTP dependency, I think for something like this its generally overkill, but we probably do need to take a TLS dependency, and at the end of the day its not our stuff anyway - we can't pick what BDK offers for their async HTTP client.

bitcoin = "0.28.1"

rand = "0.8.5"
Expand Down
Loading