Skip to content

docs: add review club 3207 #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 23, 2024
Merged

docs: add review club 3207 #41

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2ee6286
docs: small display and typo fixes
vincenzopalazzo Oct 22, 2024
d877b0e
docs: make the 3179 as done
vincenzopalazzo Oct 22, 2024
ae6a9fe
docs: add review club 3207
vincenzopalazzo Oct 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions _posts/2024-10-18-#3179.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ pr: 3179
authors: [ TheBlueMatt ]
components: ["Blinded Paths", "Human Readable Names", "Bolt12", "Offer"]
host: vincenzopalazzo
status: upcoming
status: past
commit:
---

Expand All @@ -15,9 +15,8 @@ commit:
## Question

1. Did you review [PR #3179](https://github.com/lightningdevkit/rust-lightning/pull/3179)? Is it a [Concept ACK, approach ACK, tested ACK, or NACK?](https://github.com/lightningdevkit/rust-lightning/blob/master/CONTRIBUTING.md#peer-review)
2. Did you review the [blip-0032](https://github.com/lightning/blips/blob/master/blip-0032.md)
2. Did you review the [blip-0032](https://github.com/lightning/blips/blob/master/blip-0032.md)?
3. What kind of onion messages does [blip-0032](https://github.com/lightning/blips/blob/master/blip-0032.md) define?

4. What is DNSSEC? Why is it considered secure?
- See https://www.icann.org/resources/pages/dnssec-what-is-it-why-important-2019-03-05-en/
5. What does the `struct OMNameResolver` do in `lightning/src/onion_message/dns_resolution.rs`?
Expand Down
22 changes: 22 additions & 0 deletions _posts/2024-10-25-#3207.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
---
layout: pr
date: 2024-10-25
title: "Support async payments in BOLT 12"
pr: 3207
authors: [ valentinewallace ]
components: ["Blinded Paths", "Async Payments", "Bolt12", "Offer"]
host: vincenzopalazzo
status: upcoming
commit:
---

## Notes

## Question

1. Did you review [ldk/3207](https://github.com/lightningdevkit/rust-lightning/pull/3207)? Is it a [Concept ACK, approach ACK, tested ACK, or NACK?](https://github.com/lightningdevkit/rust-lightning/blob/master/CONTRIBUTING.md#peer-review)
2. Did you review the [blot/1149](https://github.com/lightning/bolts/pull/1149)?
3. Is [blots/1149](https://github.com/lightning/bolts/pull/1149) possible to implement on the current spec? If not what is the feature that we need?

[ldk/3207]: https://github.com/lightningdevkit/rust-lightning/pull/3207
[bolt/1149]: https://github.com/lightning/bolts/pull/1149