Update to 0.2.0-beta1 and minor tweaks #141
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Naively update to LDK 0.2 using the sync wrappers to keep current behavior.
|
I've assigned @valentinewallace as a reviewer! |
Closed
|
CI sad |
|
Cause ldk 0.2 isn't uploaded yet :) |
TheBlueMatt
changed the title
Comment on lines
+216
to
+222
| // Trivially bridge the LDK FutureSpawner trait to tokio | ||
| struct TokioSpawner; | ||
| impl FutureSpawner for TokioSpawner{ | ||
| fn spawn<T: Future<Output = ()> + Send + 'static>(&self, future: T) { | ||
| tokio::spawn(future); | ||
| } | ||
| } |
There was a problem hiding this comment.
Will everyone need to do this / it should go in rust-lightning?
| let mut channelmonitors = persister.read_all_channel_monitors_with_updates().await.unwrap(); | ||
| // If you are using the `FilesystemStore` as a `Persist` directly, use | ||
| // `lightning::util::persist::read_channel_monitors` like this: | ||
| //read_channel_monitors(Arc::clone(&persister), Arc::clone(&keys_manager), Arc::clone(&keys_manager)).unwrap(); |
There was a problem hiding this comment.
nit: need space after //
TheBlueMatt
force-pushed
the
main
branch
2 times, most recently
from
63307ce to
6df8846
Compare
With LDK 0.2, most traits now offer async variants. In the previous commit we ignored these but here we migrate to them everywhere except in the `ChannelMonitor` persistence. Note that we have to switch to async stdin reading in cli.rs to ensure we always reach an `await` point in a timely manner on all tasks.
Now that we have `ChainMonitor::load_existing_monitor` we can use it during startup to avoid the excess persistence at startup.
Its always been a bit strange that we persist the addresses of our peers to disk when there's a public gossip db, its not really a thing most LN nodes do. It might be useful for private channels but there's not a lot of reason to have it in `ldk-sample`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.