This repository was archived by the owner on Jan 6, 2025. It is now read-only.
LSPS1: Get service-side working #142
Closed
+481
−652
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
.. to make it easier to switch back-and-forth when testing.
We previously didn't advertise the supported protocols, even if the corresponding service handlers were available.
.. as of LSPS#101.
.. we tremendously simplify the client logic, also dropping any state tracking for now (possibly to be re-added in the future). We also get the LSPS1 API closer to LSPS2 and make sure the API/docs is more consistent.
This reverts commit 244b1da.
tnull
force-pushed
the
2024-08-update-lsps1-service
branch
from
09ef395 to
7855d4f
Compare
|
Closing this as I'm about to archive this repository in favor of https://github.com/lightningdevkit/rust-lightning/tree/main/lightning-liquidity. Please re-open the PR over there. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #140
WIP