Fix docker setup confusions #93
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
andrei-21
commented
Apr 17, 2025
andrei-21
commented
- run the actual binary (cargo run will build a develop binary)
- copy only neccesary files during docker build
- do not expose port 8000 since it is not used by the binary
* run the actual binary (cargo run will build a develop binary) * copy only neccesary files during docker build * do not expose port 8000 since it is not used by the binary
TheBlueMatt
reviewed
Apr 17, 2025
| - BITCOIN_REST_PORT=8332 | ||
| - BITCOIN_REST_PATH=/rest/ | ||
| command: 'cargo run' | ||
| command: 'rapid-gossip-sync-server' |
Contributor
There was a problem hiding this comment.
I don't see anywhere where the actual binary is built, though? Shouldn't we instead do cargo run --release?
Contributor
Author
There was a problem hiding this comment.
It is built in docker at
Contributor
There was a problem hiding this comment.
Ah! Presumably we should drop the EXPOSE 8000 from that file as well?
Contributor
Author
There was a problem hiding this comment.
That is what I did as well ;)
TheBlueMatt
approved these changes
Apr 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.