Correct get_claimable_balance version info
#1713
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5a8ede0 updated the documentation on `get_claimable_balance` to note that if a channel went on-chain with an LDK version older than 0.0.108 some counterparty-revoked-output claimable balances my be missing. However, this failed to account for the fact that we rely on the entirely-new-in-0.0.111 `confirmed_commitment_tx_counterparty_output` field for some balances as well. Thus, the comment should have been in terms of 0.0.111, not 0.0.108.
Codecov Report
@@ Coverage Diff @@
## main #1713 +/- ##
==========================================
- Coverage 90.84% 90.83% -0.01%
==========================================
Files 86 86
Lines 46399 46399
Branches 46399 46399
==========================================
- Hits 42150 42148 -2
- Misses 4249 4251 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
wpaulino
approved these changes
Sep 9, 2022
valentinewallace
approved these changes
Sep 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
5a8ede0 updated the documentation on
get_claimable_balanceto note that if a channel went on-chain with an LDK version older than 0.0.108 somecounterparty-revoked-output claimable balances my be missing. However, this failed to account for the fact that we rely on the entirely-new-in-0.0.111
confirmed_commitment_tx_counterparty_outputfield for some balances as well.Thus, the comment should have been in terms of 0.0.111, not 0.0.108.