Fix rapid-gossip-sync no-std and properly test no-std in CI
#1756
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 90.73% // Head: 90.71% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1756 +/- ##
==========================================
- Coverage 90.73% 90.71% -0.02%
==========================================
Files 87 87
Lines 46713 46713
Branches 46713 46713
==========================================
- Hits 42383 42374 -9
- Misses 4330 4339 +9
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
While `rapid-gossip-sync` recently gained a `no-std` feature, it didn't actually work, as there were still dangling references to `std` and prelude assumptions. This makes `rapid-gossip-sync` build (and test) properly in `no-std`.
TheBlueMatt
force-pushed
the
2022-10-rgs-no-std
branch
2 times, most recently
from
c7fbeae to
a59fc4d
Compare
Given there is only one instance in our code of `AtomicU64` its simplest to just remove it rather than try to add some kind of wrapper.
TheBlueMatt
force-pushed
the
2022-10-rgs-no-std
branch
from
a59fc4d to
040a058
Compare
TheBlueMatt
force-pushed
the
2022-10-rgs-no-std
branch
from
040a058 to
7143599
Compare
tnull
reviewed
Oct 7, 2022
TheBlueMatt
force-pushed
the
2022-10-rgs-no-std
branch
from
7143599 to
976e798
Compare
Rust is incredibly forgiving in attempts to access `std`, making it rather difficult to test `no-std` properly. In practice, the only decent way to do so is to actually build for a platform that does not have `std`, which we do here by building the `no-std-check` crate for `arm-thumbv7m-none-eabi`.
TheBlueMatt
force-pushed
the
2022-10-rgs-no-std
branch
from
976e798 to
ada0df2
Compare
wpaulino
approved these changes
Oct 7, 2022
valentinewallace
approved these changes
Oct 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While
rapid-gossip-syncrecently gained ano-stdfeature, itdidn't actually work, as there were still dangling references to
stdand prelude assumptions. This makesrapid-gossip-syncbuild (and test) properly in
no-std.Ultimately, Rust is incredibly forgiving in attempts to access
std, making itrather difficult to test
no-stdproperly. In practice, the onlydecent way to do so is to actually build for a platform that does
not have
std, which we do here by building theno-std-checkcrate for
arm-thumbv7m-none-eabi.