Fix (and test) Future creation after a Notifier was notified
#1758
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After a `Notifier` has been `notify`'d, attempts to `get_future` should return a `Future` which is pre-completed, however this was not the case. This commit simply fixes the behavior, adding a test to demonstrate the issue.
Codecov ReportBase: 90.73% // Head: 90.72% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1758 +/- ##
==========================================
- Coverage 90.73% 90.72% -0.01%
==========================================
Files 87 87
Lines 46713 46721 +8
Branches 46713 46721 +8
==========================================
+ Hits 42383 42387 +4
- Misses 4330 4334 +4
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
tnull
approved these changes
Oct 7, 2022
|
Yea, probably. The public-facing docs explicitly don't provide any guarantees on which, or even how many, listeners are woken, so it doesn't really matter. |
wpaulino
approved these changes
Oct 7, 2022
|
Will leave any change in the notify for a follow-up, not that its all that critical. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After a
Notifierhas beennotify'd, attempts toget_futureshould return aFuturewhich is pre-completed, however this was not the case.This commit simply fixes the behavior, adding a test to demonstrate the issue.