Skip to content

Update full_stack_target to take an arbitrary config object #2810

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Feb 5, 2024
Merged

Update full_stack_target to take an arbitrary config object #2810

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
c725842
Disable fuzzing-reachable debug assertion
TheBlueMatt Dec 24, 2023
248e2f5
Disable fuzzing-reachable debug assertions in `ChannelMonitor`s
TheBlueMatt Dec 25, 2023
f62a96e
Use arbitrary config object in full_stack_target fuzzer
TheBlueMatt Dec 23, 2023
76ed917
Update fuzz CI job to use our MSRV rather than 1.58
TheBlueMatt Jan 18, 2024
3e0d55b
Use utility methods to construct `HashMap`s and `HashSet`s
TheBlueMatt Jan 1, 2024
efbaa41
Stop relying on `Hash{Set,Map}::from_iter` directly
TheBlueMatt Jan 18, 2024
dedc830
Bump `hashbrown` dependency to 0.13
TheBlueMatt Jan 18, 2024
c9e4410
Fix test variable typos
TheBlueMatt Jan 11, 2024
7377cc9
[fuzz] Fix slice copy in `peer_crypt_target`
TheBlueMatt Jan 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion lightning/src/chain/channelmonitor.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3172,7 +3172,11 @@ impl<Signer: WriteableEcdsaChannelSigner> ChannelMonitorImpl<Signer> {
(htlc, htlc_source.as_ref().map(|htlc_source| htlc_source.as_ref()))
), logger);
} else {
debug_assert!(false, "We should have per-commitment option for any recognized old commitment txn");
// Our fuzzers aren't contrained by pesky things like valid signatures, so can
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: constrained

// spend our funding output with a transaction which doesn't match our past
// commitment transactions. Thus, we can only debug-assert here when not
// fuzzing.
debug_assert!(cfg!(fuzzing), "We should have per-commitment option for any recognized old commitment txn");
fail_unbroadcast_htlcs!(self, "revoked counterparty", commitment_txid, tx, height,
block_hash, [].iter().map(|reference| *reference), logger);
}
Expand Down
4 changes: 3 additions & 1 deletion lightning/src/chain/onchaintx.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -806,7 +806,9 @@ impl<ChannelSigner: WriteableEcdsaChannelSigner> OnchainTxHandler<ChannelSigner>
claim_id
},
};
debug_assert!(self.pending_claim_requests.get(&claim_id).is_none());
// Because fuzzing can cause hash collisions, we can end up with conflicting claim
// ids here, so we only assert when not fuzzing.
debug_assert!(cfg!(fuzzing) || self.pending_claim_requests.get(&claim_id).is_none());
for k in req.outpoints() {
log_info!(logger, "Registering claiming request for {}:{}", k.txid, k.vout);
self.claimable_outpoints.insert(k.clone(), (claim_id, conf_height));
Expand Down