Skip to content

Conversation

@G8XSU
Copy link
Contributor

@G8XSU G8XSU commented May 6, 2024

Based on #2957

  • Stop tracking chain_sync_monitor_persistences in TestPersister
  • Minor Doc fixes
  • Make a log trace log

@codecov-commenter
Copy link

codecov-commenter commented May 6, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 90.80%. Comparing base (4d5de1f) to head (8861a9a).
Report is 44 commits behind head on main.

Files Patch % Lines
lightning/src/chain/chainmonitor.rs 0.00% 0 Missing and 1 partial ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3041      +/-   ##
==========================================
+ Coverage   89.35%   90.80%   +1.44%     
==========================================
  Files         118      118              
  Lines       98933   102957    +4024     
  Branches    98933   102957    +4024     
==========================================
+ Hits        88401    93488    +5087     
+ Misses       8267     7032    -1235     
- Partials     2265     2437     +172     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@G8XSU G8XSU force-pushed the followup-2957 branch from bd13c90 to 8861a9a Compare May 6, 2024 20:01
@G8XSU G8XSU requested a review from TheBlueMatt May 6, 2024 20:02
@TheBlueMatt
Copy link
Collaborator

Just trivial test code deletion, a log type change, and a trivial doc change, landing.

@TheBlueMatt TheBlueMatt merged commit 33b9ba5 into lightningdevkit:main May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants