Skip to content

Conversation

@optout21
Copy link
Contributor

@optout21 optout21 commented Aug 22, 2024

This PR only adds some tests for invoice serialization/deserialization, to create a test harness in preparation of Bech32 encoding changes (#3244 ).
This PR can be merged optionally, or skipped, and the tests added with #3244 . It is more clear that behavior does not change if tests are added upfront.

@codecov
Copy link

codecov bot commented Aug 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.87%. Comparing base (0d7ae86) to head (1248139).
Report is 10 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3266      +/-   ##
==========================================
+ Coverage   89.82%   89.87%   +0.05%     
==========================================
  Files         125      126       +1     
  Lines      102830   103436     +606     
  Branches   102830   103436     +606     
==========================================
+ Hits        92368    92965     +597     
- Misses       7752     7760       +8     
- Partials     2710     2711       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@optout21 optout21 changed the title Add invoice serialization/deserialization tests [TestOnly] Add invoice serialization tests [TestOnly] Aug 22, 2024
@optout21 optout21 marked this pull request as ready for review August 22, 2024 17:33
@optout21 optout21 mentioned this pull request Aug 22, 2024
4 tasks
@TheBlueMatt
Copy link
Collaborator

Otherwise LGTM, thanks.

@optout21 optout21 changed the title Add invoice serialization tests [TestOnly] Add invoice serialization tests [TestOnly][Minor] Aug 23, 2024
@TheBlueMatt TheBlueMatt merged commit c9a2c4a into lightningdevkit:main Aug 23, 2024
@optout21 optout21 deleted the bech32-tests branch August 23, 2024 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants