Skip to content

Optimize calculation of blocks to synchronize #3347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Optimize calculation of blocks to synchronize #3347

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions lightning-block-sync/src/init.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ use bitcoin::network::constants::Network;
use lightning::chain;

use std::ops::Deref;
use std::collections::HashSet;

/// Returns a validated block header of the source's best chain tip.
///
Expand Down Expand Up @@ -156,7 +157,13 @@ pub async fn synchronize_listeners<B: Deref + Sized + Send + Sync, C: Cache, L:
let mut chain_listeners_at_height = Vec::new();
let mut most_common_ancestor = None;
let mut most_connected_blocks = Vec::new();
let mut block_height_visited = HashSet::new();
for (old_header, chain_listener) in chain_listeners_with_old_headers.drain(..) {
if block_height_visited.contains(&old_header.height) {
continue;
} else {
block_height_visited.insert(old_header.height);
}
// Disconnect any stale blocks, but keep them in the cache for the next iteration.
let header_cache = &mut ReadOnlyCache(header_cache);
let (common_ancestor, connected_blocks) = {
Expand Down
Loading