Skip to content

Pin cc on Windows MSRV. #3357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 12 commits into from
Closed

Pin cc on Windows MSRV. #3357

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
c8b28d7
Pin cc on Windows MSRV.
arik-so Oct 11, 2024
c04e65c
f: try only pinning cc, without prerequisites
arik-so Oct 14, 2024
f310519
f: more pinning prerequisites
arik-so Oct 14, 2024
2064923
f: more pinning prerequisites
arik-so Oct 14, 2024
44054af
f: more pinning prerequisites
arik-so Oct 14, 2024
c333032
f: more pinning prerequisites
arik-so Oct 14, 2024
a3ec8fd
f: more pinning prerequisites
arik-so Oct 14, 2024
96c883a
f: more pinning prerequisites
arik-so Oct 14, 2024
598caed
f: more pinning prerequisites
arik-so Oct 14, 2024
ac667f0
f: more pinning prerequisites
arik-so Oct 14, 2024
9f6ec0c
f: more pinning prerequisites
arik-so Oct 14, 2024
2a3a0d8
f: more pinning prerequisites
arik-so Oct 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,16 @@ jobs:
- name: Set RUSTFLAGS to deny warnings
if: "matrix.toolchain == '1.63.0'"
run: echo "RUSTFLAGS=-D warnings" >> "$GITHUB_ENV"
- name: Pin cc on Windows MSRV
if: "matrix.toolchain == '1.63.0' && matrix.platform == 'windows-latest'"
run: |
cargo update -p [email protected] --precise "0.23.0" --verbose
Copy link
Contributor

@tnull tnull Oct 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't we just pin cc?

I don't think we should pin rustls and all the other crypto crates (even if it's just on Windows).

Copy link
Contributor Author

@arik-so arik-so Oct 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had originally tried to pin an older version of cc, so I tried again for this one. The short answer is no, I'm afraid.

cargo update -p [email protected] --precise "0.102.2" --verbose
cargo update -p aws-lc-rs --precise "1.6.0" --verbose
cargo update -p aws-lc-sys --precise "0.13.0" --verbose
cargo update -p ring --precise "0.17.0" --verbose
cargo update -p cmake --precise "0.1.48" --verbose
cargo update -p cc --precise "1.0.72" --verbose
- name: Enable caching for bitcoind
id: cache-bitcoind
uses: actions/cache@v4
Expand Down
Loading