Remove deprecated re-exports #3359
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheBlueMatt
force-pushed
the
2024-10-less-types-re-export
branch
from
409c2e0 to
42b89a9
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3359 +/- ##
==========================================
+ Coverage 89.61% 89.67% +0.05%
==========================================
Files 127 127
Lines 103533 103822 +289
Branches 103533 103822 +289
==========================================
+ Hits 92785 93106 +321
+ Misses 8051 8045 -6
+ Partials 2697 2671 -26 ☔ View full report in Codecov by Sentry. |
TheBlueMatt
force-pushed
the
2024-10-less-types-re-export
branch
from
42b89a9 to
a9f6ecc
Compare
These were deprecated in 0.0.124, and we drop them here in favor of `lightning::types::features::*`.
TheBlueMatt
force-pushed
the
2024-10-less-types-re-export
branch
3 times, most recently
from
800715e to
7d7d739
Compare
tnull
reviewed
Oct 14, 2024
Contributor
tnull
left a comment
tnull
left a comment
There was a problem hiding this comment.
Unfortunately CI fails in the RUSTFLAGS=' --cfg=ldk_test_vectors'step
TheBlueMatt
force-pushed
the
2024-10-less-types-re-export
branch
2 times, most recently
from
b27c380 to
376755d
Compare
Collaborator
Author
|
Fixed, plus taproot build. |
These re-exports were deprecated in 0.0.124 in favor of the `lightning::types::payment::*` paths, which we use here.
Like we've done for `features` and `payment`, here we mark the `lightning::util::string` re-export as deprecated.
TheBlueMatt
force-pushed
the
2024-10-less-types-re-export
branch
from
376755d to
57dcc7d
Compare
G8XSU
previously approved these changes
Oct 17, 2024
Now that the module only contains some implementations of serialization for the `lightning_types::features` structs, there's no reason for it to be public.
TheBlueMatt
force-pushed
the
2024-10-less-types-re-export
branch
from
ac000bd to
b5b3860
Compare
G8XSU
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the re-exports that were deprecated in 0.0.124 and adds one more deprecation. Almost fixes #3251 but doesn't cause of the last deprecation addition, at least it fixes it for the purposes of 0.1.