Skip to content

Conversation

@vincenzopalazzo
Copy link
Contributor

I really do not have any clue why the ci is failing here https://github.com/lightningdevkit/rust-lightning/actions/runs/11683772490/job/32533657424?pr=3397 so trying out stuff

Signed-off-by: Vincenzo Palazzo <[email protected]>
@vincenzopalazzo vincenzopalazzo marked this pull request as ready for review November 5, 2024 15:03
@vincenzopalazzo
Copy link
Contributor Author

Ok probably I found the problem but I do not have any idea why it is happening

I was able to reproduce in a pure nix shell

nix-shell -p rustup --pure
cargo install cargo-llvm-cov
export RUSTFLAGS="-Clink-dead-code"
cargo llvm-cov --features rest-client,rpc-client,tokio,futures,serde --codecov --hide-instantiations --output-path=target/codecov.json

I do not know the history of the flag link-dead-code but around the internet, I read that the error can be a mismatch version between some dependencies, but not sure.

Copy link
Collaborator

@TheBlueMatt TheBlueMatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like just a bug in rustc, might as well just take this and see if codecov gets mad.

@TheBlueMatt TheBlueMatt merged commit 8c086c7 into lightningdevkit:main Nov 5, 2024
18 of 20 checks passed
@vincenzopalazzo vincenzopalazzo deleted the macros/fixing-ci branch November 6, 2024 09:11
vincenzopalazzo added a commit to vincenzopalazzo/rust-lightning that referenced this pull request Nov 6, 2024
…macros/fixing-ci"

This reverts commit 8c086c7, reversing
changes made to d33284f.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants