Pin indexmap back to account for hashbrown MSRV bump
#3402
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`indexmap` 2.6.0 upgraded to `hashbrown` 0.15, which unfortunately bumped their MSRV to rustc 1.65 with the 0.15.1 release. So we pin `indexmap` to 2.5.0 to fix our MSRV CI.
tnull
force-pushed
the
2024-11-pin-indexmap
branch
from
73e6066 to
e12ee9d
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3402 +/- ##
==========================================
- Coverage 89.68% 89.67% -0.02%
==========================================
Files 128 128
Lines 104891 104891
Branches 104891 104891
==========================================
- Hits 94076 94065 -11
- Misses 8114 8123 +9
- Partials 2701 2703 +2 ☔ View full report in Codecov by Sentry. |
TheBlueMatt
approved these changes
Nov 7, 2024
Collaborator
TheBlueMatt
left a comment
TheBlueMatt
left a comment
There was a problem hiding this comment.
I'm starting to think we should move the lightning-transaction-sync crate back out of the workspace and increase its MSRV until we can replace its HTTP stack with something more conservative.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... here we go again.
indexmap2.6.0 upgraded tohashbrown0.15, which unfortunately bumped their MSRV to rustc 1.65 with the 0.15.1 release. So we pinindexmapto 2.5.0 to fix our MSRV CI.