Skip to content

Type Renames for lightning-liquidity bindings #3574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

Type Renames for lightning-liquidity bindings #3574

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
546559f
Mark static method string as `'static`
TheBlueMatt Jan 29, 2025
db41005
Rename `lightning-liquidity`'s `Event` `LSPSEvent`
TheBlueMatt Jan 29, 2025
f3085bb
Remove unnecessary bounds on `LSPS2ServiceHandler`
TheBlueMatt Jan 29, 2025
3e87194
Rename `lightning-liquidity`'s LSPS1 things to avoid conflicts
TheBlueMatt Jan 29, 2025
5be9c1a
Rename `lightning-liquidity`'s LSPS2 things to avoid confusion
TheBlueMatt Jan 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions lightning-liquidity/src/lsps2/service.rs
View file
Open in desktop
Copy link
Contributor

@tnull tnull Jan 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, these bounds are (going) to be necessary as we're cloing the ChannelManager reference for the LSPS1ServiceHandler. It's just not surfaced as it lives behind cfg(lsps1_service) for now. Assuming we don't want to macroize the bounds, I'd propose to drop this commit for now.

Original file line number Diff line number Diff line change
Expand Up @@ -550,7 +550,7 @@ macro_rules! get_or_insert_peer_state_entry {
}

/// The main object allowing to send and receive LSPS2 messages.
pub struct LSPS2ServiceHandler<CM: Deref + Clone>
pub struct LSPS2ServiceHandler<CM: Deref>
where
CM::Target: AChannelManager,
{
Expand All @@ -564,7 +564,7 @@ where
config: LSPS2ServiceConfig,
}

impl<CM: Deref + Clone> LSPS2ServiceHandler<CM>
impl<CM: Deref> LSPS2ServiceHandler<CM>
where
CM::Target: AChannelManager,
{
Expand Down Expand Up @@ -1345,7 +1345,7 @@ where
}
}

impl<CM: Deref + Clone> ProtocolMessageHandler for LSPS2ServiceHandler<CM>
impl<CM: Deref> ProtocolMessageHandler for LSPS2ServiceHandler<CM>
where
CM::Target: AChannelManager,
{
Expand Down