rustfmt: Run on offers
#3577
rustfmt: Run on offers
#3577
Conversation
|
After the conflicts are resolved here, I don't have a strong opinion on how it's formatted things, so LGTM. |
tnull
force-pushed
the
2025-01-rustfmt-offers
branch
from
16a7ba1 to
ce2a568
Compare
Resolved conflicts. |
TheBlueMatt
left a comment
TheBlueMatt
left a comment
There was a problem hiding this comment.
There's about two pending PRs touching this module that should land today or early next week, then lets land this.
lightning/src/offers/merkle.rs
Outdated
| "02080000010000020003" | ||
| }; | ||
| } | ||
| macro_rules! tlv3 { () => { "03310266e4598d1d3c415f572a8488830b60f7e744ed9235eb0b1ba93283b315c0351800000000000000010000000000000002" } } |
There was a problem hiding this comment.
Why didn't this get updated?
There was a problem hiding this comment.
Because rustfmt at times avoids touching macros. Not sure if a bug or a feature.
Now made it a constant anyways.
|
Needs rebase, not sure if there's any remaining PRs touching this code? I don't think so. |
tnull
force-pushed
the
2025-01-rustfmt-offers
branch
from
ce2a568 to
3297ddb
Compare
Rebased and addressed comments. |
tnull
force-pushed
the
2025-01-rustfmt-offers
branch
from
3297ddb to
f38c88f
Compare
TheBlueMatt
left a comment
TheBlueMatt
left a comment
There was a problem hiding this comment.
Gonna land this to get it out of the way.
| } | ||
|
|
||
| /// Verifies that the request was for an offer created using the given key by checking a nonce | ||
| /// Verifies that the request was for an offer created using the given key by checking a nonce |
| /// Verifies that the request was for an offer created using the given key by checking the | ||
| macro_rules! invoice_request_verify_method { | ||
| ($self: ident, $self_type: ty) => { | ||
| /// Verifies that the request was for an offer created using the given key by checking the |
|
|
||
| let recipient_pubkey = { | ||
| let secret_key = SecretKey::from_slice(&<Vec<u8>>::from_hex("4141414141414141414141414141414141414141414141414141414141414141").unwrap()).unwrap(); | ||
| let secret_bytes = <Vec<u8>>::from_hex( |
There was a problem hiding this comment.
Same with all these, please don't let a simple from_hex turn into 4 LoC.
3 participants
We run the formatter on the
offerssub-directory.