Track amount_msat field in Event::PaymentSent
#3599
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| /// | ||
| /// [`ChannelManager::send_payment`]: crate::ln::channelmanager::ChannelManager::send_payment | ||
| payment_hash: PaymentHash, | ||
| /// The total amount that was paid, across all paths. |
Contributor
There was a problem hiding this comment.
LGTM. Might be worth noting that fees are excluded from this number? We do that on the equivalent Route method.
Contributor
Author
There was a problem hiding this comment.
Added a note in a fixup commit.
Contributor
|
Feel free to squash! |
Previously, we would only track the fees paid, but not the actual amount that was sent.
tnull
force-pushed
the
2025-02-track-amount-in-payment-sent
branch
from
ecc1f22 to
e5d46c5
Compare
Contributor
Author
Squashed without further changes. |
valentinewallace
approved these changes
Feb 14, 2025
TheBlueMatt
approved these changes
Feb 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we would only track the fees paid, but not the actual amount that was sent.
This seems like an obvious omission and has us issuing unnecessary store lookups just to be able to log the amount in LDK Node.