Use proper libm power method for f64s
#3661
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For some reason when attempting to raise floats to powers in scoring we'd converted our `f64`s to `f32`s, called `libm::powf` (on no-std targets), then converted the result back to an `f64`. `libm::pow`, however, exists and raises `f64`s to a power natively. Here we correct this, using the proper `f64`-native `pow`. While I doubt its related, I went to look if we have any conversion in LDK itself in response to lightningdevkit/ldk-node#483 (where Android binaries failed to load due to a missing `__extenddftf2`.
|
I've assigned @arik-so as a reviewer! |
arik-so
approved these changes
Mar 11, 2025
|
👋 The first review has been submitted! Do you think this PR is ready for a second reviewer? If so, click here to assign a second reviewer. |
|
✅ Added second reviewer: @valentinewallace |
Collaborator
Author
|
Honestly, this is trivial. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason when attempting to raise floats to powers in scoring we'd converted our
f64s tof32s, calledlibm::powf(on no-std targets), then converted the result back to anf64.libm::pow, however, exists and raisesf64s to a power natively.Here we correct this, using the proper
f64-nativepow.While I doubt its related, I went to look if we have any conversion in LDK itself in response to
lightningdevkit/ldk-node#483 (where Android binaries failed to load due to a missing
__extenddftf2.