Skip to content

Conversation

@tnull
Copy link
Contributor

@tnull tnull commented Apr 9, 2025

We run the formatter on some smallish files.

@ldk-reviews-bot
Copy link

ldk-reviews-bot commented Apr 9, 2025

👋 Thanks for assigning @TheBlueMatt as a reviewer!
I'll wait for their review and will help manage the review process.
Once they submit their review, I'll check if a second reviewer would be helpful.

Copy link
Contributor

@vincenzopalazzo vincenzopalazzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@martinsaposnic martinsaposnic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I wasn’t aware of rustfmt_excluded_files, I'm curious why it's needed

joostjager
joostjager previously approved these changes Apr 9, 2025
Copy link
Collaborator

@TheBlueMatt TheBlueMatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one nit

@TheBlueMatt
Copy link
Collaborator

I wasn’t aware of rustfmt_excluded_files, I'm curious why it's needed

Because, sadly, rustfmt on some of our files creates some really unreadable results. So we're doing it iteratively, applying it to more and more files over time and removing things from the excluded list.

@codecov
Copy link

codecov bot commented Apr 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.50%. Comparing base (46cb5ff) to head (8df643d).
Report is 13 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3724      +/-   ##
==========================================
+ Coverage   89.11%   89.50%   +0.39%     
==========================================
  Files         156      156              
  Lines      123435   125924    +2489     
  Branches   123435   125924    +2489     
==========================================
+ Hits       109995   112713    +2718     
+ Misses      10758    10541     -217     
+ Partials     2682     2670      -12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor Author

@tnull tnull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Going ahead landing this with one ACK as it's trivial and the nit was addressed.

@tnull tnull merged commit 85185d8 into lightningdevkit:main Apr 10, 2025
25 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants