Contribute funding inputs on accepting dual-funded channel #3735
Conversation
|
👋 I see @jkczyz was un-assigned. |
dunxen
force-pushed
the
2025-04-contributeinputs
branch
from
e22fa33 to
fabbf86
Compare
dunxen
force-pushed
the
2025-04-contributeinputs
branch
4 times, most recently
from
c42f3d0 to
186d66b
Compare
dunxen
force-pushed
the
2025-04-contributeinputs
branch
from
186d66b to
c7d8e89
Compare
dunxen
force-pushed
the
2025-04-contributeinputs
branch
from
c7d8e89 to
540b8a7
Compare
|
Looks like this needs a rebase after #3637 |
dunxen
force-pushed
the
2025-04-contributeinputs
branch
from
540b8a7 to
94bf848
Compare
ugh right! |
|
Don't the first three commits need to be dropped? |
dunxen
force-pushed
the
2025-04-contributeinputs
branch
2 times, most recently
from
67504f0 to
9f276d8
Compare
|
Just needs node reload tests but it can still get some initial review. |
dunxen
force-pushed
the
2025-04-contributeinputs
branch
from
9f276d8 to
60f58b1
Compare
| script_pubkey: funding.get_funding_redeemscript().to_p2wsh(), | ||
| }; | ||
|
|
||
| // Optionally add change output |
There was a problem hiding this comment.
Wouldn't this already be covered by begin_interactive_funding_tx_construction?
There was a problem hiding this comment.
Oh indeed. begin_interactive_funding_tx_construction was modified to include that in a previous pre-splicing work. Thanks.
| }; | ||
|
|
||
| // Optionally add change output | ||
| let change_script = signer_provider.get_destination_script(context.channel_keys_id) |
There was a problem hiding this comment.
Maybe let the user optionally provide a change address along with their inputs?
|
Since the |
|
🔔 1st Reminder Hey @jkczyz! This PR has been waiting for your review. |
|
🔔 2nd Reminder Hey @jkczyz! This PR has been waiting for your review. |
Agreed. Apologies for the late response. Back home now. I'll split it into a separate PR and we can discuss changes. |
|
🔔 3rd Reminder Hey @jkczyz! This PR has been waiting for your review. |
dunxen
force-pushed
the
2025-04-contributeinputs
branch
2 times, most recently
from
9a2a5ce to
8006303
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #3735 +/- ##
==========================================
+ Coverage 89.32% 89.61% +0.29%
==========================================
Files 180 181 +1
Lines 138176 138525 +349
Branches 138176 138525 +349
==========================================
+ Hits 123424 124141 +717
+ Misses 12137 11774 -363
+ Partials 2615 2610 -5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
🔔 4th Reminder Hey @jkczyz! This PR has been waiting for your review. |
1 similar comment
1 similar comment
1 similar comment
1 similar comment
1 similar comment
1 similar comment
1 similar comment
1 similar comment
1 similar comment
|
Sorry, long time. This needs a super rebase. I see #1621 was closed. Do we need another issue for dual-funding tracking? |
Yeah, probably best to use a fresh issue than re-open an older one that's accumulated the splicing work. |
…annel We introduce a `ChannelManager::accept_inbound_channel_with_contribution` method allowing contributing to the overall channel capacity of an inbound dual-funded channel by contributing inputs.
We can now run through the case where the acceptor contributes to an inbound channel, with either more value in inputs, or less value, leading to a different `tx_signatures` exchange order. We also cannot use dummy P2WPKH funding inputs and witnesses anymore as `funding_transaction_signed` internally verifies signatures. Hence, we create external keypairs that we can create outputs for and sign with.
jkczyz
force-pushed
the
2025-04-contributeinputs
branch
from
c059e03 to
fe940d6
Compare
|
Rebased! Will take over the PR from here 🫡 |
4 participants
We introduce a
ChannelManager::accept_inbound_channel_with_contributionmethod allowing contributing to the overall channel capacity of an inbound
dual-funded channel by contributing inputs.