Rustfmt events #3773
Rustfmt events #3773
Conversation
|
👋 Thanks for assigning @valentinewallace as a reviewer! |
| lightning/src/chain/onchaintx.rs | ||
| lightning/src/chain/package.rs | ||
| lightning/src/chain/transaction.rs | ||
| lightning/src/events/bump_transaction.rs |
There was a problem hiding this comment.
Guess this basically conflicts with your PR and it hasn't gotten to review yet so seems fine to do.
There was a problem hiding this comment.
I do the magic script, no problem
|
👋 The first review has been submitted! Do you think this PR is ready for a second reviewer? If so, click here to assign a second reviewer. |
Co-authored-by: Matt Corallo <[email protected]>
joostjager
force-pushed
the
rustfmt-events
branch
from
ee8df0d to
c9624fc
Compare
|
@TheBlueMatt squashed your changes and rustfmt'ed the formatting fixes. |
| None => { | ||
| Ok(PaymentPurpose::Bolt11InvoicePayment { | ||
| payment_preimage, | ||
| payment_secret, | ||
| }) | ||
| }, | ||
| Some(PaymentContext::Bolt12Offer(context)) => { | ||
| Ok(PaymentPurpose::Bolt12OfferPayment { | ||
| payment_preimage, | ||
| payment_secret, | ||
| payment_context: context, | ||
| }) | ||
| }, | ||
| None => Ok(PaymentPurpose::Bolt11InvoicePayment { payment_preimage, payment_secret }), | ||
| Some(PaymentContext::Bolt12Offer(context)) => Ok(PaymentPurpose::Bolt12OfferPayment { |
There was a problem hiding this comment.
Rustfmt made something less vertical 😮
There was a problem hiding this comment.
It does do that quite often, tho sometimes when it does that I find it annoying 😂
dunxen
left a comment
dunxen
left a comment
There was a problem hiding this comment.
I get the same diff with rustfmt, and doesn't seem horrendous to me so LGTM
5 participants
Noticing the no-rustfmt penalty again when working on bump_transaction.rs. These files look completely fine to me as is.