Replace rustfmt_excluded_files with rustfmt_skip cfg attribute #3802
Conversation
|
👋 Thanks for assigning @tnull as a reviewer! |
valentinewallace
left a comment
valentinewallace
left a comment
There was a problem hiding this comment.
Thanks, this looks great and works in my text editor!
lightning/src/ln/update_fee_tests.rs
Outdated
| check_closed_event!(nodes[1], 1, reason, [node_a_id], channel_value); | ||
| } | ||
|
|
||
| #[xtest(feature = "_externalize_tests")] |
There was a problem hiding this comment.
Are the update_fee_test and channel.rs changes intentional? It seems like they could use their own commit if so
There was a problem hiding this comment.
I have really no idea how that slipped through. Reverted.
joostjager
force-pushed
the
rustfmt-skip
branch
3 times, most recently
from
1176fc2 to
e7af289
Compare
|
Requested @tnull's review since @TheBlueMatt is off review this week, so hopefully we can land. |
tnull
left a comment
tnull
left a comment
There was a problem hiding this comment.
Sure, why not. One comment, otherwise LGTM.
This change removes the custom `rustfmt_excluded_files` mechanism and instead uses the an attribute at the top of each excluded file. No functional changes are introduced. This simplifies formatting workflows by enabling standard `cargo fmt` and editor format-on-save features without custom scripts. The older `rustfmt` cfg attribute is used because newer formatting directives only support code blocks, which would require more effort to apply consistently. This commit focuses on improving developer experience by streamlining formatting setup, while more granular or comprehensive formatting can be addressed later.
tnull
left a comment
tnull
left a comment
There was a problem hiding this comment.
LGTM
Landing this as the changes since Val's ACK are minimal.
4 participants
This change removes the custom
rustfmt_excluded_filesmechanism and instead uses an attribute at the top of each excluded file.No functional changes are introduced. This simplifies formatting workflows by enabling standard
cargo fmtand editor format-on-save features without custom scripts.The older
rustfmtcfg attribute is used because newer formatting directives only support code blocks, which would require more effort to apply consistently. This commit focuses on improving developer experience by streamlining formatting setup, while more granular or comprehensive formatting can be addressed later.