Remove (and deny) useless test vec!s
#3883
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 Thanks for assigning @tnull as a reviewer! |
tnull
previously approved these changes
Jun 23, 2025
Contributor
tnull
left a comment
tnull
left a comment
There was a problem hiding this comment.
LGTM. Happy to land as soon as CI let's us, as it's trivial.
Contributor
|
@TheBlueMatt seems Github is of the opinion this needs a rebase already. Also CI is hanging in a weird way here. |
TheBlueMatt
force-pushed
the
2025-06-no-test-useless-vecs
branch
from
c062d97 to
0af6620
Compare
In the next commit we'll set clippy to ban useless `vec!`s in tests, so here we remove them.
There's no reason to allow these, and now that they've been removed, we should simply deny them in tests like we do in normal code.
TheBlueMatt
force-pushed
the
2025-06-no-test-useless-vecs
branch
from
0af6620 to
6091c4a
Compare
|
👋 The first review has been submitted! Do you think this PR is ready for a second reviewer? If so, click here to assign a second reviewer. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Had this one lying around after #3851 so figured its worth doing before it gets stale.