Skip to content

Fix multiplication overflow when logging hold times. #3888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 24, 2025
Merged

Fix multiplication overflow when logging hold times. #3888

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lightning/src/ln/onion_utils.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1226,7 +1226,7 @@ where
logger,
"Htlc hold time at pos {}: {} ms",
route_hop_idx,
hold_time * HOLD_TIME_UNIT_MILLIS as u32
(hold_time as u128) * HOLD_TIME_UNIT_MILLIS
Copy link
Contributor

@tnull tnull Jun 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed this would make an overflow highly unlikely, but saturating_mul would actually make it impossible. Doesn't matter much, as it's just in logging anyways.

);

// Shift attribution data to prepare for processing the next hop.
Expand Down
Loading