Skip to content

Conversation

tnull
Copy link
Contributor

@tnull tnull commented Jul 24, 2025

Closes #3948.

Previously, the incremental-mutants CI job was failing on ~every PR that made actual logic changes, and nobody seemed to really make any effort to address the failures. The failing CI jobs therefore just resulted in additional which in turn could have us getting used to failing CI, introducing some risk of acutal failures slipping through. Of course, it also took up some (considerable?) time in the CI queue that might be better spent on other jobs if no contributors are actually benefitting from the CI job.

Here we therefore drop incremental-mutants from our CI for the time being.

Previously, the `incremental-mutants` CI job was failing on ~every PR that made actual logic changes, and nobody seemed to really make any effort to address the failures. The failing CI jobs therefore just resulted in additional which in turn could have us getting used to failing CI, introducing some risk of acutal failures slipping through. Of course, it also took up some (considerable?) time in the CI queue that might be better spent on other jobs if no contributors are actually benefitting from the CI job.

Here we therefore drop `incremental-mutants` from our CI for the time
being.
@ldk-reviews-bot
Copy link

ldk-reviews-bot commented Jul 24, 2025

👋 Thanks for assigning @TheBlueMatt as a reviewer!
I'll wait for their review and will help manage the review process.
Once they submit their review, I'll check if a second reviewer would be helpful.

@tnull tnull marked this pull request as draft July 24, 2025 08:39
@tnull tnull changed the title Drop incremental-mutants CI job Drop incremental-mutants CI job (main) Jul 24, 2025
@tnull
Copy link
Contributor Author

tnull commented Jul 24, 2025

Will undraft once we reach a conclusive decision on #3948.

Copy link

codecov bot commented Jul 24, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.94%. Comparing base (65d518b) to head (36116be).
⚠️ Report is 51 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3953      +/-   ##
==========================================
- Coverage   88.95%   88.94%   -0.02%     
==========================================
  Files         168      174       +6     
  Lines      121974   123876    +1902     
  Branches   121974   123876    +1902     
==========================================
+ Hits       108502   110181    +1679     
- Misses      11072    11245     +173     
- Partials     2400     2450      +50     
Flag Coverage Δ
fuzzing 22.17% <ø> (-0.52%) ⬇️
tests 88.77% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tnull tnull marked this pull request as ready for review July 27, 2025 09:37
@tnull
Copy link
Contributor Author

tnull commented Jul 27, 2025

Discussed this at the dev sync, everybody seemed to be in favor or at least not against dropping it. So undrafting.

@TheBlueMatt TheBlueMatt merged commit 6b7e9f9 into lightningdevkit:main Jul 28, 2025
27 checks passed
@tnull
Copy link
Contributor Author

tnull commented Jul 28, 2025

Ugh, seems this has us now always failing check_commits on the main branch CI: https://github.com/lightningdevkit/rust-lightning/actions/runs/16568852275/job/46855508579

Will put up a fix.

@tnull
Copy link
Contributor Author

tnull commented Jul 28, 2025

Should be fixed in #3966

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Consider dropping incremental_mutants CI job

3 participants