Skip to content

Conversation

TheBlueMatt
Copy link
Collaborator

cargo can get excited seeing it has many available cores and will happily spawn core-count ld processes to link all the fuzzing binaries, using substantial very-short-term memory. This can cause issues in CI runners with many cores but not a ton of memory (eg 32 cores and only 16GiB of memory available).

@ldk-reviews-bot
Copy link

ldk-reviews-bot commented Jul 28, 2025

👋 Thanks for assigning @tnull as a reviewer!
I'll wait for their review and will help manage the review process.
Once they submit their review, I'll check if a second reviewer would be helpful.

`cargo` can get excited seeing it has many available cores and will
happily spawn core-count `ld` processes to link all the fuzzing
binaries, using substantial very-short-term memory. This can cause
issues in CI runners with many cores but not a ton of memory (eg
32 cores and only 16GiB of memory available).
@TheBlueMatt TheBlueMatt force-pushed the 2025-07-less-fuzzing-mem branch from 906744c to db4890d Compare July 28, 2025 19:09
Copy link

codecov bot commented Jul 28, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.92%. Comparing base (7ec13dc) to head (db4890d).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3970   +/-   ##
=======================================
  Coverage   88.92%   88.92%           
=======================================
  Files         174      174           
  Lines      123869   123869           
  Branches   123869   123869           
=======================================
+ Hits       110152   110156    +4     
+ Misses      11256    11255    -1     
+ Partials     2461     2458    -3     
Flag Coverage Δ
fuzzing 22.18% <ø> (ø)
tests 88.75% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tnull tnull requested review from tnull and removed request for valentinewallace July 28, 2025 20:43
Copy link
Contributor

@tnull tnull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense.

@ldk-reviews-bot
Copy link

👋 The first review has been submitted!

Do you think this PR is ready for a second reviewer? If so, click here to assign a second reviewer.

@tnull tnull merged commit 66be919 into lightningdevkit:main Jul 28, 2025
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants