Trampoline Forwarding: Enforce trampoline constraints #3983
Conversation
|
👋 Thanks for assigning @valentinewallace as a reviewer! |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #3983 +/- ##
==========================================
- Coverage 88.94% 88.85% -0.09%
==========================================
Files 174 175 +1
Lines 124575 128121 +3546
Branches 124575 128121 +3546
==========================================
+ Hits 110797 113846 +3049
- Misses 11278 11713 +435
- Partials 2500 2562 +62
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
|
🔔 1st Reminder Hey @tankyleo! This PR has been waiting for your review. |
|
👋 The first review has been submitted! Do you think this PR is ready for a second reviewer? If so, click here to assign a second reviewer. |
|
Also when I remove everything but the test code, the test does not fail - is that intentional ? I have not reviewed the test |
|
thanks @tankyleo !
Double checked the tests and yes, this happens because when receiving a trampoline it behaves exactly as receiving a non-trampoline payment. Having the same failure scenario. I added fixups for each of your comments and rebased in top of main |
a-mpch
force-pushed
the
2025-08-enforce-trampoline-constraint
branch
from
4deaa3e to
d37d6d8
Compare
|
Also go ahead and squash next time you push, and expand the commit message to describe in detail what you are doing, including in the tests :) Would help me out with reviewing the code too thank you ! |
a-mpch
force-pushed
the
2025-08-enforce-trampoline-constraint
branch
from
d37d6d8 to
3515844
Compare
|
@tankyleo Reading the initial PR needed a lot of explanation work 😅, thanks for the detailed review! All your comments should have been addressed and rebased and squashed. note that linting CI seems to be a problem on one of the new commits after rebase |
a-mpch
force-pushed
the
2025-08-enforce-trampoline-constraint
branch
from
3515844 to
5c6f023
Compare
a-mpch
force-pushed
the
2025-08-enforce-trampoline-constraint
branch
from
5c6f023 to
c41c202
Compare
This commit adds three new local htlc failure error reasons: `TemporaryTrampolineFailure`, `TrampolineFeeOrExpiryInsufficient`, and `UnknownNextTrampoline` for trampoline payment forwarding failures.
a-mpch
force-pushed
the
2025-08-enforce-trampoline-constraint
branch
from
c41c202 to
ccd103f
Compare
We add a `check_trampoline_constraints` similar to `check_blinded_path_constraints` that compares the Trampoline onion's amount and CLTV values to the limitations imposed by the outer onion. Also, we add and modify the following tests: - Modified the unblinded receive to validate when receiving amount less than expected. - Modified test with wrong CLTV parameters that now fails with new enforcement of CLTV limits. - Add unblinded and blinded receive tests that forces trampoline onion's CLTV to be greater than the outer onion packet. Note that there are some TODOs to be fixed in following commits as we need the full trampoline forwarding feature to effectively test all cases. Co-authored-by: Arik Sosman <[email protected]>
a-mpch
force-pushed
the
2025-08-enforce-trampoline-constraint
branch
from
ccd103f to
91f5296
Compare
This PR is part of 1/N PRs in order to split up #3976
This commit checks amount and CLTV of the trampoline to the outer hop. If exceeds limitations we fail the forward using a
InboundHTLCErrwith specified local reason.