Fix lifetime elision warnings introduced by rustc 1.89 #3992
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The just-released rustc 1.89 added a new `mismatched-lifetime-syntaxes` lint which had three new warnings pop up. We fix these here.
|
👋 Thanks for assigning @TheBlueMatt as a reviewer! |
Contributor
Author
|
Oh common. Seems the new lints werent even valid syntax in 1.63 :( |
tnull
force-pushed
the
2025-08-fix-lifetime-elision-lints
branch
3 times, most recently
from
63b2837 to
c898345
Compare
Contributor
Author
|
Grrr. I think we should just fix this by bumping MSRV to rustc 1.85 soon :( |
Collaborator
Can we open a rustc issue, then? That's a really obnoxious default lint. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The just-released rustc 1.89 added a new
mismatched-lifetime-syntaxeslint which had three new warnings pop up. We fix these here.(See https://releases.rs/docs/1.89.0/)