Skip to content

Conversation

martinsaposnic
Copy link
Contributor

@martinsaposnic martinsaposnic commented Aug 7, 2025

Fixes #3990

Use rust-lld linker for windows to fix link.exe error

@ldk-reviews-bot
Copy link

ldk-reviews-bot commented Aug 7, 2025

I've assigned @joostjager as a reviewer!
I'll wait for their review and will help manage the review process.
Once they submit their review, I'll check if a second reviewer would be helpful.

@martinsaposnic
Copy link
Contributor Author

seems to be working, didn't fail at the 12min mark

@martinsaposnic martinsaposnic changed the title Use rust-lld linker for windows to fix link.exe error Fix windows CI Aug 7, 2025
Copy link

codecov bot commented Aug 7, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.92%. Comparing base (de2005a) to head (e1edbde).
⚠️ Report is 10 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3995      +/-   ##
==========================================
- Coverage   88.93%   88.92%   -0.01%     
==========================================
  Files         174      174              
  Lines      124539   124539              
  Branches   124539   124539              
==========================================
- Hits       110758   110751       -7     
- Misses      11287    11289       +2     
- Partials     2494     2499       +5     
Flag Coverage Δ
fuzzing 22.18% <ø> (ø)
tests 88.75% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@TheBlueMatt TheBlueMatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@TheBlueMatt TheBlueMatt merged commit 381416a into lightningdevkit:main Aug 7, 2025
23 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Windows CI failing

3 participants